Skip to content

Treat code reviewers team members as maintainers - #140

Merged
bjester merged 1 commit into
learningequality:mainfrom
rtibblesbot:issue-139-22c37c
Nov 13, 2026
Merged

bjester merged 1 commit into
learningequality:mainfrom
rtibblesbot:issue-139-22c37c

Conversation

@rtibblesbot

@rtibblesbot rtibblesbot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • learning-equality-code-reviewers members got contributor greetings and community labels
  • Adds the team to MAINTAINER_TEAMS

References

Fixes #139. Follows #134.

Reviewer guidance

Suggested review: Full code review.

Engineer review

  • Skipped here, so verify it: The app token can read membership of learning-equality-code-reviewers. (needs a workflow run in a learningequality repo with the bot app's token)
  • docs/community-automations.md replaces the stale constants.js#L44 anchors with one [assign-keywords] reference to #L51, beyond the issue's deliverables.
  • the app token can read learning-equality-code-reviewers membership; a 404 there makes every code reviewer a contributor silently, and a 403 fails every is-contributor run (scripts/utils.js:58-59).
Engineer evidence
  • Open risk: untested whether the app token can read this team's membership; if not, the check 404s and members silently stay contributors.

AI usage

Used Claude Code to write the change, the test and the doc anchor fix. Verified with the full test suite and the prek hooks.


Written by rtibblesbot, an LLM-based coding agent.

@rtibblesbot

🟡 Waiting for feedback

Last updated: 2026-11-13 02:26 UTC

Add `learning-equality-code-reviewers` to `MAINTAINER_TEAMS`. Point the
assign keyword links in community-automations.md at the moved constant.

Closes learningequality#139

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rtibblesbot
rtibblesbot marked this pull request as ready for review November 13, 2026 02:25
@rtibblesbot
rtibblesbot requested review from a team and leq-bot November 13, 2026 02:25

@bjester bjester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjester
bjester merged commit 976b246 into learningequality:main Nov 13, 2026
157 of 170 checks passed
@rtibblesbot

Copy link
Copy Markdown
Contributor Author

Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific.

@rtibblesbot
rtibblesbot deleted the issue-139-22c37c branch November 13, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Members of the Learning Equality code reviewers team are treated as contributors

2 participants