feat: Update SS with evals for Grade 5-12#5
Merged
adnanrhussain merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
gary-mu
reviewed
Jan 12, 2026
Contributor
gary-mu
left a comment
There was a problem hiding this comment.
Love this integration of grade 5-12.
2 comments:
- Can we also add Ariena as reviewer? She's not a member of this repo, so I can't add her
- Can we add test result? I think running test passages and paste result can be sufficient.
|
Overall LGTM. Two small callouts:
|
aychi1
approved these changes
Jan 16, 2026
aychi1
left a comment
There was a problem hiding this comment.
Overall LGTM. Commented on some non-blocking nits.
Contributor
Author
Note: Updated the PR description to include the test script used, and the test results validating the changes. |
d76247f to
3ab2493
Compare
gary-mu
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the Sentence Structure Evaluator (notebook) to support grades 5-12, beyond the existing grades 3-4 support.
Key Changes
get_rubric_for_grade()to dynamically select appropriate rubricDocumentation
Testing
Test cases covering grades 2-6 with expected complexity scores. Multi-attempt testing validates consistency.
Please expand to review the test script
Test Script
Please expand to review the test results
Test Results
Status
🔄 Under internal review and testing before release.
Breaking Changes
None - backwards compatible.