feat: create asNode/mkNode abstraction for DiscrTree - #14911
Open
robsimmons wants to merge 3 commits into
Open
Conversation
robsimmons
marked this pull request as draft
August 24, 2026 12:50
robsimmons
force-pushed
the
push-kqpzqvxlpnyl
branch
from
August 24, 2026 12:51
1cd9ea7 to
e99ccf6
Compare
robsimmons
changed the title
robsimmons
changed the title
robsimmons
marked this pull request as ready for review
August 24, 2026 13:02
robsimmons
added
the
changelog-no
nomeata
reviewed
Aug 24, 2026
| -/ | ||
| @[inline] | ||
| def Trie.asNode : Trie α → Array α × Array (Key × Trie α) | ||
| | .node vs cs => ⟨vs, cs⟩ |
Collaborator
There was a problem hiding this comment.
We might want to offer .value and .children as well so far users who care about only don't don't have to materialize the other (which, depending on future implementation changes, maybe not be cheap)?
Contributor
Author
There was a problem hiding this comment.
@nomeata only concern there would be that DiscrTree.values is recursive - Trie.nodeValues and Trie.nodeChildren make sense for you?
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates an additional view abstraction on
DiscrTree.Trienodes that allows nodes to be viewed and inspected without direct case analysis.This interface allows downstream code to tolerate future minor changes to DiscrTree representations (e.g. #12838 or #14805) more gracefully than is currently possible.