fix: adjust name mangling in kernel's nested inductive type processing - #14846
Draft
kmill wants to merge 1 commit into
Draft
fix: adjust name mangling in kernel's nested inductive type processing#14846kmill wants to merge 1 commit into
kmill wants to merge 1 commit into
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This PR fixes an issue where the kernel would not accept nested inductive types where the type being nested through was public with a private constructor. The kernel assumed that the name of the inductive type was a prefix of each constructor. Now the kernel uses a simpler procedure where the auxiliary type's name is prepended to constructor names, rather than replacing a prefix. Note that a consequence to this is that auxiliary recursors have non-atomic minor premise names (which was already the case for private constructors). With @berberman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the kernel would not accept nested inductive types where the type being nested through was public with a private constructor. The kernel assumed that the name of the inductive type was a prefix of each constructor. Now the kernel uses a simpler procedure where the auxiliary type's name is prepended to constructor names, rather than replacing a prefix. Note that a consequence to this is that auxiliary recursors have non-atomic minor premise names (which was already the case for private constructors).
With @berberman
Closes #10789