fix: keep sse session alive with comment lines#52
Merged
Conversation
Vtec234
approved these changes
Jul 2, 2026
Vtec234
left a comment
Vtec234
left a comment
Member
There was a problem hiding this comment.
Nice! Btw, for /_vs/ requests we turn off this autoclosing but it seems good to keep it for Next.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the SSE connection drops (after 60 seconds at ngnix, the lying machine told me) if the toolchain download takes too long. Comment lines are a standard fix to prevent that (says the vague memories in my own brain and what I implemented in comparator-live).