refactor(QM): Improve/golf LRL proofs#1019
Merged
jstoobysmith merged 9 commits intoleanprover-community:masterfrom Apr 2, 2026
Merged
refactor(QM): Improve/golf LRL proofs#1019jstoobysmith merged 9 commits intoleanprover-community:masterfrom
jstoobysmith merged 9 commits intoleanprover-community:masterfrom
Conversation
Contributor
Author
|
t-quantum-mechanics |
Contributor
Author
|
RFC |
github-actions
bot
added
t-quantum-mechanics
jstoobysmith
approved these changes
Apr 2, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved - will merge shortly
|
|
||
| /-- The operator `𝐱ᵢ𝐩ᵢ` on Schwartz maps. -/ | ||
| private def positionDotMomentum {d} := ∑ i : Fin d, 𝐱[i] ∘L 𝐩[i] | ||
| private def positionDotMomentum (d : ℕ) := ∑ i : Fin d, 𝐱[i] ∘L 𝐩[i] |
Member
There was a problem hiding this comment.
I wonder if there is a way to define this type of dot product in general, so we wouldn't need a separate definition for each of them.
Contributor
Author
There was a problem hiding this comment.
You mean to subsume not only positionDotMomentum but also ∑ i, 𝐩[i] ∘L 𝐩[i], ∑ i, ∑ j, 𝐋[i,j] ∘L 𝐋[i,j], etc? Yeah, that could be nice - I will think on how to do this.
Member
There was a problem hiding this comment.
Yeah exactly. If you can get all three with the same definition it would be great, but even just the first two would be nice.
jstoobysmith
added
ready-to-merge
gloges
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes progress in improving/golfing the proofs for the LRL vector, taking advantage of the Kronecker delta api (c.f. #979) and commutator simp lemmas (
@[simp]added in #994).