Skip to content

chore(Analysis/Normed/Unbundled/RingSeminorm): add missing API - #43111

Open
tb65536 wants to merge 3 commits into
leanprover-community:masterfrom
tb65536:tb_extr843
Open

chore(Analysis/Normed/Unbundled/RingSeminorm): add missing API#43111
tb65536 wants to merge 3 commits into
leanprover-community:masterfrom
tb65536:tb_extr843

Conversation

@tb65536

@tb65536 tb65536 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR adds some missing API in Analysis/Normed/Unbundled/RingSeminorm.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-analysis Analysis (normed *, calculus) labels Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR summary ea23c8f9a6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ ofAbsoluteValue
+ toAbsoluteValue
+ toMulRingNorm_apply
+ toMulRingSeminorm_apply
+ toRingNorm_apply
+ toRingSeminorm_apply
- mulRingNormEquivAbsoluteValue_apply
- mulRingNormEquivAbsoluteValue_symm_apply

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit ea23c8f).

  • +9 new declarations
  • −0 removed declarations
+AlgebraNorm.toRingNorm_apply
+MulAlgebraNorm.toMulRingNorm_apply
+MulRingNorm.ofAbsoluteValue
+MulRingNorm.ofAbsoluteValue.congr_simp
+MulRingNorm.ofAbsoluteValue_toFun
+MulRingNorm.toAbsoluteValue
+MulRingNorm.toAbsoluteValue_apply
+MulRingNorm.toMulRingSeminorm_apply
+RingNorm.toRingSeminorm_apply

No changes to strong technical debt.
No changes to weak technical debt.

Current commit ea23c8f9a6
Reference commit d2dd159404

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant