Skip to content

chore(GroupTheory/PGroup): to_additivize most of the file - #43102

Open
tb65536 wants to merge 9 commits into
leanprover-community:masterfrom
tb65536:tb_add498
Open

chore(GroupTheory/PGroup): to_additivize most of the file#43102
tb65536 wants to merge 9 commits into
leanprover-community:masterfrom
tb65536:tb_add498

Conversation

@tb65536

@tb65536 tb65536 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR to_additivizes most of GroupTheory/PGroup.lean.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory labels Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR summary 54d3dd7c6a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isAddPGroup

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 54d3dd7).

  • +65 new declarations
  • −0 removed declarations
+IsAddPGroup
+IsAddPGroup.addOrderOf_coprime
+IsAddPGroup.card
+IsAddPGroup.card_eq_or_dvd
+IsAddPGroup.card_modEq_card_fixedPoints
+IsAddPGroup.card_orbit
+IsAddPGroup.comap_of_injective
+IsAddPGroup.comap_of_ker_isAddPGroup
+IsAddPGroup.comap_subtype
+IsAddPGroup.coprime_card_of_ne
+IsAddPGroup.disjoint_of_coprime
+IsAddPGroup.disjoint_of_ne
+IsAddPGroup.dvd_addOrderOf
+IsAddPGroup.exists_addOrderOf_dvd_nsmul
+IsAddPGroup.exists_addOrderOf_eq_nsmul
+IsAddPGroup.exists_card_dvd_nsmul
+IsAddPGroup.exists_card_eq
+IsAddPGroup.exists_exponent_dvd_nsmul
+IsAddPGroup.exists_exponent_eq_nsmul
+IsAddPGroup.exists_fixed_point_of_prime_dvd_card_of_fixed_point
+IsAddPGroup.exists_nsmul_nsmul_eq_zero
+IsAddPGroup.iff_addOrderOf
+IsAddPGroup.iff_card
+IsAddPGroup.index
+IsAddPGroup.isOfFinAddOrder
+IsAddPGroup.ker_isAddPGroup_of_injective
+IsAddPGroup.le_or_disjoint_of_coprime
+IsAddPGroup.map
+IsAddPGroup.mono
+IsAddPGroup.nonempty_fixed_point_of_prime_not_dvd_card
+IsAddPGroup.nontrivial_iff_card
+IsAddPGroup.nsmulEquiv
+IsAddPGroup.nsmulEquiv'
+IsAddPGroup.nsmulEquiv_apply
+IsAddPGroup.nsmulEquiv_symm_apply
+IsAddPGroup.of_bot
+IsAddPGroup.of_card
+IsAddPGroup.of_card_dvd_nsmul
+IsAddPGroup.of_equiv
+IsAddPGroup.of_exponent_dvd_nsmul
+IsAddPGroup.of_injective
+IsAddPGroup.of_nsmul
+IsAddPGroup.of_subsingleton
+IsAddPGroup.of_surjective
+IsAddPGroup.to_addSubgroup
+IsAddPGroup.to_inf_left
+IsAddPGroup.to_inf_right
+IsAddPGroup.to_le
+IsAddPGroup.to_quotient
+IsAddPGroup.to_sup_of_normal_left
+IsAddPGroup.to_sup_of_normal_left'
+IsAddPGroup.to_sup_of_normal_right
+IsAddPGroup.to_sup_of_normal_right'
+IsAddPGroup.zero
+ZModModule.isAddPGroup
+isAddPGroup_iff_addOrderOf_dvd_nsmul
+isAddPGroup_iff_card_dvd_nsmul
+isAddPGroup_iff_exists_addOrderOf_dvd_nsmul
+isAddPGroup_iff_exists_nsmul_nsmul_eq_zero
+isAddPGroup_iff_exponent_dvd_nsmul
+isAddPGroup_iff_exponent_eq_nsmul
+isAddPGroup_iff_isAddPGroup_sum_primeFactors
+isAddPGroup_iff_nsmul_nsmul_eq_zero
+isAddPGroup_iff_primeFactors_card_subset
+isAddPGroup_zero_iff_subsingleton

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 54d3dd7c6a
Reference commit 661ab0bdd3

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/GroupTheory/PGroup.lean Outdated
Comment thread Mathlib/GroupTheory/PGroup.lean Outdated
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 25, 2026
Comment thread Mathlib/GroupTheory/PGroup.lean Outdated
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants