Skip to content

[Window] Replace std::wstring_convert with native Windows string conversion APIs - #588

Closed
stephenduong1004 wants to merge 1 commit into
leanflutter:mainfrom
stephenduong1004:codecvt
Closed

stephenduong1004 wants to merge 1 commit into
leanflutter:mainfrom
stephenduong1004:codecvt

Conversation

@stephenduong1004

Copy link
Copy Markdown

This PR replaces std::wstring_convert with the native Windows string conversion APIs, as <codecvt> header and std:: wstring_convert are getting removed. NFC.

@lijy91

lijy91 commented Sep 21, 2026

Copy link
Copy Markdown
Member

Thank you for the PR, and sorry it sat here so long. window_manager 0.5.x is no longer maintained: from 0.6.0 window_manager is rebuilt on nativeapi (Flutter package: nativeapi), and the platform code in this repo's main branch goes away, so I'm closing PRs against it.

nativeapi doesn't use std::wstring_convert / <codecvt>; it already converts with the Win32 APIs, so nothing needs porting there.

@lijy91 lijy91 closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants