Repository navigation
fix(validator): bound XMSS preparation progress - #1213
Open
groverInnovate wants to merge 2 commits into
Open
groverInnovate wants to merge 2 commits into
groverInnovate wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The validator's preparation loop can repeatedly rebuild trees for a slot outside key activation or behind the prepared window. Reject those slots before advancing, and reject an advancement that makes no forward progress, so an impossible duty cannot keep the service busy indefinitely.
Add service-level regressions for both proposal and attestation keys: activation boundaries, a discarded preparation window, no-progress advancement, rejection followed by valid signing, and successful multi-window advancement with role isolation. Preparation does not track signing history; this change adds no non-reuse policy.
Validation: the new cases yield 8 failures and 2 passes on the base revision, and all pass with the fix. Full unit suite: 2,137 passed .
just checkandjust deadcodepass using existing cached tooling.Related Issues or PRs
Separate from the signing-history policy in #1204.