Import issues#2829
Conversation
|
Seems to be working now |
There was a problem hiding this comment.
Can you show the output of executing this with the lpython built from latest main branch? I would like to see this test getting failed with the current lpython.
There was a problem hiding this comment.
Current lpython main
% src/bin/lpython test.py -I.
ASR verify pass error: Module __main__ dependencies must contain string because a function present in it is getting called in __main__.
Internal Compiler Error: Unhandled exception
^C
cpython
% python3 test.py
Inside import
lpython after changes
% src/bin/lpython test.py -I.
Inside import
ubaidsk
left a comment
There was a problem hiding this comment.
lgtm
I think we can merge once we see output for https://github.com/lcompilers/lpython/pull/2829/files#r2004399682.
|
Oh ye there is another thing i noticed. When the compiler crashes and hangs integration tests don't stop and give and error (afaik i may have waited too little). If there is no check for that I think we need to add a TLE exit on each test |
|
This PR also fixes a related problem foo.py print("Inside import")main.py import fooLpython current main Cpython Lpython after changes I'll add an stdout test for this too |
|
@Shaikh-Ubaid all done i think. I'll continue checking for bugs, I have midterms coming so might be less active |
|
I'm having some problems with tests can someone help? |
|
If its possible i'd prefer if we merge just the approved changes before adding the tests |
|
You will need to remove those extra commits. |
|
@Shaikh-Ubaid just did also if you are free I had a question on Zulip |
This PR is regarding the first part of #2828 this does seem to fix part of the problem but I think it fails integration tests because it hangs when trying to create the lnn pkg i'm not entirely sure why