Skip to content

fix: make PermissionShield tooltip placement adaptive to viewport #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruveshmishra wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −18
Open

fix: make PermissionShield tooltip placement adaptive to viewport #1776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c96f1ef
fix: make PermissionShield tooltip placement adaptive to viewport (#1…
dhruveshmishra Aug 5, 2026
9ae5098
Merge branch 'master' into fixing-tools
dhruveshmishra Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 35 additions & 18 deletions src/custom/permissions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ export interface PermissionShieldProps {
permissionKey: PermissionKeySpec;
children: React.ReactNode;
variant?: 'inline' | 'badge';
boundaryPadding?: {
top?: number;
left?: number;
right?: number;
bottom?: number;
};
}

/** Distinct, defined values in first-seen order — used for the metadata chips. */
Expand All @@ -93,14 +99,18 @@ const uniqueDefined = (values: (string | undefined)[]): string[] =>
export const PermissionShield: React.FC<PermissionShieldProps> = ({
permissionKey,
children,
variant = 'inline'
variant = 'inline',
boundaryPadding
}) => {
const [open, setOpen] = React.useState(false);
const [copiedKeyId, setCopiedKeyId] = React.useState<string | null>(null);
const uniqueId = React.useId();
const userContext = usePermissionUserContext();
const unmetKeys = useUnmetPermissionKeys(permissionKey);

const defaultPadding = { top: 85, left: 270, right: 8, bottom: 8 };
const padding = boundaryPadding ? { ...defaultPadding, ...boundaryPadding } : defaultPadding;

const handleClose = () => {
setOpen(false);
};
Expand Down Expand Up @@ -419,31 +429,38 @@ export const PermissionShield: React.FC<PermissionShieldProps> = ({
disableTouchListener
slotProps={{
popper: {
modifiers: [
{
name: 'flip',
enabled: true,
options: {
fallbackPlacements: ['bottom', 'right', 'left']
}
},
{
name: 'preventOverflow',
enabled: true,
options: {
boundary: 'viewport',
altAxis: true,
padding: 8
popperOptions: {
modifiers: [
{
name: 'flip',
enabled: true,
options: {
boundary: 'viewport',
fallbackPlacements: ['right', 'bottom', 'left'],
padding
}
Comment thread
dhruveshmishra marked this conversation as resolved.
},
{
name: 'preventOverflow',
enabled: true,
options: {
boundary: 'viewport',
tether: false,
altAxis: true,
padding
}
}
}
]
]
}
},
tooltip: {
sx: {
background: '#1A1A1A',
color: '#FFFFFF',
maxWidth: 360,
minWidth: 300,
maxHeight: '320px',
overflowY: 'auto',
padding: '12px',
borderLeft: '4px solid #EBC024',
borderRadius: '8px',
Expand Down
Loading