fix: move permission shield to bottom-left for disabled badge components#1743
fix: move permission shield to bottom-left for disabled badge components#1743Salmaan-M wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesPermission shield placement
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Salmaan-M <133296753+Salmaan-M@users.noreply.github.com>
6beb961 to
5f9e39d
Compare
|
@rishiraj38 This change is limited to the positioning of the PermissionShield badge overlay within Sistent (top-right → bottom-left) and doesn't affect its behavior or logic. Given that it's a small visual adjustment in the shared component, so I haven't yet verified it in Meshery. If you'd prefer, I'm happy to validate it against Meshery before this is merged. |
Notes for Reviewers
Description
Moves the permission shield overlay for the
badgevariant from the top-right corner to the bottom-left corner, matching the expected UI described in #1731.Changes
PermissionShieldbadge positioning:top: -6→bottom: -6right: -6→left: -6This PR fixes #1731
Signed commits
Summary by CodeRabbit