Skip to content

fix: move permission shield to bottom-left for disabled badge components#1743

Open
Salmaan-M wants to merge 1 commit into
layer5io:masterfrom
Salmaan-M:fix/permission-shield-bottom-left
Open

fix: move permission shield to bottom-left for disabled badge components#1743
Salmaan-M wants to merge 1 commit into
layer5io:masterfrom
Salmaan-M:fix/permission-shield-bottom-left

Conversation

@Salmaan-M

@Salmaan-M Salmaan-M commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

Description

Moves the permission shield overlay for the badge variant from the top-right corner to the bottom-left corner, matching the expected UI described in #1731.

Changes

  • Updated the PermissionShield badge positioning:
    • top: -6bottom: -6
    • right: -6left: -6

This PR fixes #1731

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the permission shield badge overlay positioning to better align visually.
    • The “badge” variant now uses a different offset direction (moving the overlay to the opposite corner area) for more consistent placement.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d0aad6e-ec04-4e6c-a67f-e7fb495406a0

📥 Commits

Reviewing files that changed from the base of the PR and between 6beb961 and 5f9e39d.

📒 Files selected for processing (1)
  • src/custom/permissions.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/custom/permissions.tsx

📝 Walkthrough

Walkthrough

The PermissionShield badge overlay is repositioned from the top-right corner to the bottom-left corner. Permission-checking behavior and public exports remain unchanged.

Changes

Permission shield placement

Layer / File(s) Summary
Reposition badge overlay
src/custom/permissions.tsx
The badge variant changes its absolute offsets from top/right to bottom/left.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: moving the permission shield to the bottom-left for disabled badge components.
Linked Issues check ✅ Passed The code change directly fulfills issue #1731 by moving the permission shield from the top-right to the bottom-left.
Out of Scope Changes check ✅ Passed The PR only changes the shield overlay position and adds no unrelated behavior or scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Salmaan-M <133296753+Salmaan-M@users.noreply.github.com>
@Salmaan-M
Salmaan-M force-pushed the fix/permission-shield-bottom-left branch from 6beb961 to 5f9e39d Compare July 23, 2026 15:06
@Salmaan-M

Copy link
Copy Markdown
Contributor Author

@rishiraj38 This change is limited to the positioning of the PermissionShield badge overlay within Sistent (top-right → bottom-left) and doesn't affect its behavior or logic.

Given that it's a small visual adjustment in the shared component, so I haven't yet verified it in Meshery. If you'd prefer, I'm happy to validate it against Meshery before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Place the Permission Shield at the Bottom-Left of Disabled Components

1 participant