feat: add permissionKey support to NavigationNavbar#1741
Open
rishiraj38 wants to merge 5 commits into
Open
Conversation
…avigationNavbar Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughNavigationNavbar now supports permission-key and action-based gating for top-level and nested items while retaining legacy boolean permissions. NavigationItem and NavigationNavbar are re-exported through package entry points. ChangesPermission-aware navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
rishiraj38
changed the title
rishiraj38
marked this pull request as draft
July 22, 2026 19:45
rishiraj38
marked this pull request as ready for review
July 22, 2026 19:45
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/base/Checkbox/index.tsx`:
- Line 4: Propagate the new public symbols through every required barrel: update
src/base/Checkbox/index.tsx, src/base/Select/index.tsx, and
src/base/TextField/index.tsx for CheckboxProps, SelectProps, and TextFieldProps
respectively, then re-export those symbols from the base-domain barrel and
src/index.tsx; also re-export NavigationItem from src/custom/index.tsx and the
root barrel. Ensure each symbol is available through its feature-local, domain,
and root exports.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c4c2722f-3cdf-4505-b60d-f8f2e64464d4
📒 Files selected for processing (9)
src/base/Checkbox/Checkbox.tsxsrc/base/Checkbox/index.tsxsrc/base/Select/Select.tsxsrc/base/Select/index.tsxsrc/base/TextField/TextField.tsxsrc/base/TextField/index.tsxsrc/custom/NavigationNavbar/index.tsxsrc/custom/NavigationNavbar/navigationNavbar.tsxsrc/custom/index.tsx
…kbox Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
rishiraj38
changed the title
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
NavigationItem (and NavigationNavbar's own declaration) reached the root
barrel only through `export * from './custom'`, which rollup-plugin-dts
drops from the bundled d.ts - so `import { type NavigationItem } from
'@sistent/sistent'` failed type-checking downstream despite the runtime
export existing. Add an explicit root re-export following the established
FeedbackButton pattern to force both declarations into the published bundle.
Signed-off-by: marblom007 <158522975+marblom007@users.noreply.github.com>
Contributor
|
@coderabbitai review |
✅ Action performedReview finished.
|
Member
|
CodeRabbit, you're a lazy bastard. |
leecalcote
approved these changes
Jul 23, 2026
Document the rollup-plugin-dts nested-barrel declaration-drop quirk that this PR's NavigationItem/NavigationNavbar fix addresses, so future maintainers adding custom exports know to add an explicit re-export in src/index.tsx and verify against the built dist/index.d.ts. Signed-off-by: marblom007 <158522975+marblom007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances Sistent components (
NavigationNavbar) by adding nativepermissionKeyandpermissionActionsupport, seamlessly integrating them into Sistent'sPermissionShieldauthorization system.Key Changes
NavigationNavbarComponent: AddedpermissionKey?: KeytoNavigationIteminterface and passed through toMenuItemfor automatic PermissionShield tooltips.NavigationItemtype from root barrel exports.WhatsApp.Video.2026-07-24.at.02.00.30.mp4
Signed commits
Summary by CodeRabbit
New Features
permissionKey+permissionAction.NavigationItemtype for consumers.Bug Fixes
NavigationNavbarandNavigationItemcan be imported reliably.Documentation
disttype declarations.