Skip to content

[Data] Fix invalid JSON in kanvas_discuss.json#1107

Closed
Amertos wants to merge 3 commits into
layer5io:masterfrom
Amertos:master
Closed

[Data] Fix invalid JSON in kanvas_discuss.json#1107
Amertos wants to merge 3 commits into
layer5io:masterfrom
Amertos:master

Conversation

@Amertos

@Amertos Amertos commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1106 by removing the invalid HTML (301 Moved Permanently response) from kanvas_discuss.json and replacing it with an empty array [] to allow the build to pass.

Signed-off-by: Amertos amer.hasira.mist123@gmail.com

Signed commits

  • Yes, I signed my commits.

Amertos added 2 commits June 20, 2026 11:24
Signed-off-by: Amer <amer.hasira.mist123@gmail.com>
Closes layer5io#1106 Signed-off-by: Amertos <amer.hasira.mist123@gmail.com>

Signed-off-by: Amer <amer.hasira.mist123@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces an invalid HTML redirect page in data/kanvas_discuss.json with an empty JSON array. The reviewer points out that this will cause Hugo build or rendering errors because the templates expect a specific object structure containing users and topic_list.topics. They suggest initializing the file with an empty object structure matching the expected schema instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread data/kanvas_discuss.json Outdated
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1107/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Amer <amer.hasira.mist123@gmail.com>
@saurabhraghuvanshii

Copy link
Copy Markdown
Member

not correct fix . refer this #1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure in preview due to invalid JSON

2 participants