Skip to content

chore(make): standardize Makefile structure#1104

Open
Sbragul26 wants to merge 4 commits into
layer5io:masterfrom
Sbragul26:standardize-makefiles
Open

chore(make): standardize Makefile structure#1104
Sbragul26 wants to merge 4 commits into
layer5io:masterfrom
Sbragul26:standardize-makefiles

Conversation

@Sbragul26

Copy link
Copy Markdown
Member

Notes for Reviewers

This PR makes the Makefiles consistent across [docs] repositories. It aligns the structure, targets, and commands used in the Makefiles.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sbragul26 <sbragul26@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Makefile and package.json to introduce new local and Docker-based build, dependency checking, and testing targets. Feedback on these changes highlights two critical issues in the Makefile: first, parsing go.mod using grep and awk in the docker-update-modules target is fragile and should be replaced with go list -m; second, the docker-build-upstream target is missing the HUGO_MODULE_REPLACEMENTS environment variable, which is necessary to correctly build the upstream version.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant