Skip to content

fix: resolve Dependabot security alerts in example lockfiles and bump esbuild #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kparkinson-ld wants to merge 1 commit into from
Closed

fix: resolve Dependabot security alerts in example lockfiles and bump esbuild #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/async-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@
"webpack-serve": "^3.1.1"
},
"resolutions": {
"acorn": "npm:acorn-with-stage3"
"acorn": "npm:acorn-with-stage3",
"node-forge": "^1.4.0",
"tmp": "^0.2.6"
Comment on lines +64 to +65

@joker23 joker23 Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which dep(s) are these transitive to? wondering why we can't just update a base level dependency.

@devin-ai-integration devin-ai-integration Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-forge@0.10.0 is transitive via universal-hot-reload → webpack-dev-server@3.11.0 → selfsigned → node-forge. The root cause is webpack-dev-server v3 which pins selfsigned@^1.10.0, and that version of selfsigned requires node-forge@^0.10.0. Upgrading universal-hot-reload or webpack-dev-server to a version that doesn't pull in old selfsigned would require jumping to webpack-dev-server v5 (breaking).

tmp@0.0.33 is transitive via eslint@5.16.0 → inquirer → external-editor → tmp. The root cause is the very old eslint@^5.10.0 pinned in the example's devDependencies — eslint 5.x is EOL and its dep chain pulls in ancient tmp. Upgrading eslint in these examples would require reworking the eslint config.

Both are cases where the direct dependency is too old to resolve the transitive vuln through a normal version bump, so resolutions are the pragmatic fix without a larger rewrite of these deprecated examples.

}
}
Loading
Loading