Skip to content

fix: align FDv2 goodbye event with spec (reason-only) #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Apr 30, 2026
+5 −16
Merged

fix: align FDv2 goodbye event with spec (reason-only) #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ldclient/impl/datasourcev2/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,7 @@ def _process_message(

if msg.event == EventName.GOODBYE:
goodbye = Goodbye.from_dict(json.loads(msg.data))
if not goodbye.silent:
log.error(
"SSE server received error: %s (%s)",
goodbye.reason,
goodbye.catastrophe,
)
log.info("SSE server sent goodbye: %s", goodbye.reason)

return None

Expand Down
10 changes: 2 additions & 8 deletions ldclient/impl/datasystem/protocolv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,13 @@ class Goodbye:
"""

reason: str
silent: bool
catastrophe: bool

def to_dict(self) -> dict:
"""
Serializes the Goodbye to a JSON-compatible dictionary.
"""
return {
"reason": self.reason,
"silent": self.silent,
"catastrophe": self.catastrophe,
}

@staticmethod
Expand All @@ -139,13 +135,11 @@ def from_dict(data: dict) -> "Goodbye":
Deserializes a Goodbye event from a JSON-compatible dictionary.
"""
reason = data.get("reason")
silent = data.get("silent")
catastrophe = data.get("catastrophe")

if reason is None or silent is None or catastrophe is None:
if reason is None:
raise ValueError("Missing required fields in Goodbye JSON.")

return Goodbye(reason=reason, silent=silent, catastrophe=catastrophe)
return Goodbye(reason=reason)


@dataclass(frozen=True)
Expand Down
2 changes: 1 addition & 1 deletion ldclient/testing/impl/datasourcev2/test_polling_synchronizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def events() -> dict:
data=json.dumps(selector.to_dict()),
)

goodbye = Goodbye(reason="test reason", silent=True, catastrophe=False)
goodbye = Goodbye(reason="test reason")
goodbye_event = Event(
event=EventName.GOODBYE,
data=json.dumps(goodbye.to_dict()),
Expand Down
2 changes: 1 addition & 1 deletion ldclient/testing/impl/datasourcev2/test_streaming_synchronizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def events() -> dict:
data=json.dumps(selector.to_dict()),
)

goodbye = Goodbye(reason="test reason", silent=True, catastrophe=False)
goodbye = Goodbye(reason="test reason")
goodbye_event = Event(
event=EventName.GOODBYE,
data=json.dumps(goodbye.to_dict()),
Expand Down
Loading