fix(react-sdk): basicLogger was not re-exported causing compile time errors - #1843
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
kinyoklion
approved these changes
Aug 7, 2026
Merged
joker23
pushed a commit
that referenced
this pull request
Aug 7, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>client-testing-plugin: 1.0.10</summary> ## [1.0.10](client-testing-plugin-v1.0.9...client-testing-plugin-v1.0.10) (2026-08-07) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/react-sdk bumped from 4.1.11 to 4.1.12 * peerDependencies * @launchdarkly/react-sdk bumped from ^4.1.4 to ^4.1.12 </details> <details><summary>react-sdk: 4.1.12</summary> ## [4.1.12](react-sdk-v4.1.11...react-sdk-v4.1.12) (2026-08-07) ### Bug Fixes * **react-sdk:** `basicLogger` was not re-exported causing compile time errors ([#1843](#1843)) ([459c891](459c891)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Release Please cut for **`@launchdarkly/react-sdk` 4.1.12** and **`@launchdarkly/client-testing-plugin` 1.0.10**, with manifest, package versions, changelogs, and example apps aligned on the new React SDK version. > > **4.1.12** is documented as restoring the **`basicLogger`** re-export from `@launchdarkly/js-client-sdk` so imports like `import { basicLogger } from '@launchdarkly/react-sdk'` compile again ([#1843](#1843)). This PR also updates the default **`wrapperVersion`** in `LDReactClient` to `4.1.12`. > > The testing plugin release only bumps **peer/dev** dependency ranges to **`@launchdarkly/react-sdk` ^4.1.12**; no plugin source changes appear in the diff. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit af55e9c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#1842
Describe the solution you've provided
re-export
baseLoggerfrom base packageDescribe alternatives you've considered
The following considerations were rejected:
baseLogger) - rejected because this would technically be a breaking change to the APIreact-sdkusers will need to use something from the basejs-client-sdk.Additional context
I've added an import of
baseLoggerin an example which would serve as a regression test.Note
Low Risk
Adds a single public re-export and example-only usage; no runtime behavior change for existing consumers unless they adopt the new import.
Overview
Re-exports
basicLoggerfrom@launchdarkly/js-client-sdkon the React SDK’s public entry (packages/sdk/react/src/client/index.ts), so apps can import it from@launchdarkly/react-sdkwithout compile errors (issue #1842).The bootstrap example now imports
basicLoggerfrom the React package and passes it vialdOptions.logger, documenting logger override and acting as a regression guard.Reviewed by Cursor Bugbot for commit 0559003. Bugbot is set up for automated code reviews on this repo. Configure here.