Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
joker23
force-pushed
the
skz/remove-prettier-bare
branch
from
c50da18 to
619c7e0
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just removes our
prettierdependency and its usageNOTE: if we merge this then we will have a period of time where we would not have a code formatter, this PR is isolated to break up our larger change to introduce
stylisticand modernize our eslint implementationNote
Low Risk
Low risk because changes are confined to developer tooling and package scripts, but CI/local
checkflows change since formatting is no longer enforced or run.Overview
Removes Prettier entirely from the repo’s tooling. Deletes
.prettierrc/.prettierignore, dropseslint-config-prettierandeslint-plugin-prettierusage, and removes theprettier/prettierrule from.eslintrc.js.Updates root and package-level
package.jsonfiles to removeprettierscripts fromcheckpipelines and to drop Prettier-related devDependencies (including the import-sorting plugin). Also removes a now-unneeded// eslint-disable-next-line prettier/prettiercomment in the browser contract-test entrypoint.Reviewed by Cursor Bugbot for commit 619c7e0. Bugbot is set up for automated code reviews on this repo. Configure here.