Skip to content

chore: enforce npm min-release-age dependency cooldown - #59

Open
joker23 wants to merge 4 commits into
mainfrom
devin/1785963925-js-sdk-common-cooldown
Open

chore: enforce npm min-release-age dependency cooldown#59
joker23 wants to merge 4 commits into
mainfrom
devin/1785963925-js-sdk-common-cooldown

Conversation

@joker23

@joker23 joker23 commented Aug 5, 2026

Copy link
Copy Markdown

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Supply chain hardening for legacy SDK repositories, mirroring js-core's yarn npmMinimalAgeGate: 4320 (3 days).

Describe the solution you've provided

  • Add .npmrc with min-release-age=3 (npm expresses this in days), so npm resolves only versions published more than 3 days ago. Unlike a Dependabot-level setting, this applies to every install — local development and CI alike.
  • min-release-age-exclude explicitly names the first-party packages this repo actually resolves (launchdarkly-eventsource, launchdarkly-js-client-sdk, launchdarkly-js-sdk-common), so LaunchDarkly patches can be adopted immediately while third-party releases stay quarantined. Names are listed individually rather than pattern matched.

Describe alternatives you've considered

Dependabot cooldown — only governs Dependabot PRs, and these legacy repos aren't aiming to stay continuously updated.

Additional context

Verified locally with npm 12: npm install and the test suite pass with the gate active. CI is green.

Link to Devin session: https://app.devin.ai/sessions/566f0d951dfa4568b67ad0c6c1cfb7c1
Requested by: @joker23


Note

Low Risk
Configuration-only change with no application logic; install behavior may differ briefly if a needed third-party version is newer than three days.

Overview
Introduces a repository-level npm install gate (min-release-age=3) so dependency resolution prefers versions published more than three days ago, aligning with js-core’s yarn age gate for supply-chain hardening.

min-release-age-exclude lists launchdarkly-eventsource, launchdarkly-js-client-sdk, and launchdarkly-js-sdk-common so internal LaunchDarkly packages are not delayed; third-party releases remain subject to the cooldown on every npm install, including CI and local dev.

Reviewed by Cursor Bugbot for commit 025f634. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23 joker23 self-assigned this Aug 5, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@cursor review

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration devin-ai-integration Bot changed the title chore: add dependabot config with 7-day dependency cooldown chore: enforce npm min-release-age dependency cooldown Aug 5, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

devin-ai-integration Bot and others added 2 commits August 7, 2026 13:56
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@joker23
joker23 marked this pull request as ready for review August 7, 2026 14:42
@joker23
joker23 requested a review from a team as a code owner August 7, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant