chore: bump electron devDependency from ^7.2.4 to ^39.8.5 - #55
chore: bump electron devDependency from ^7.2.4 to ^39.8.5#55kparkinson-ld wants to merge 1 commit into
Conversation
Resolves all 29 open Dependabot alerts (4 high, 18 medium, 4 low severity). All alerts were for the electron devDependency, which is used only for the test infrastructure and is not shipped to consumers of the SDK.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
I don't think this is going to work. Could you test the change with https://github.com/launchdarkly/hello-electron and see if the SDK could still work after updating. |
|
@joker23 Good call to verify. I tested this and here are the results: SDK unit tests pass with electron 39: The electron devDep is not shipped to consumers: hello-electron has a pre-existing issue unrelated to this PR: One thing to note: The SDK's |
Requirements
N/A — devDependency-only change, no application code affected.
Related issues
Resolves all 29 open Dependabot alerts (#1–#29), all targeting the
electrondevDependency.Describe the solution you've provided
Bumps the
electrondevDependency from^7.2.4to^39.8.5inpackage.json. This resolves all 29 Dependabot security alerts:electronis a devDependency used only for the test runner (@jest-runner/electron). It is not shipped to consumers of the SDK, so this change has no impact on the published package.Describe alternatives you've considered
Additional context
spectron(deprecated, used only in integration tests via separate jest config) is incompatible with Electron 39.x but is not part of any Dependabot alert. It can be addressed in a follow-up if integration tests need to run.eslint) passes cleanly. TypeScript errors innode_modules/@types/nodeare pre-existing onmain(oldtypescript@^3.9.7vs modern type definitions) and unrelated to this change.Link to Devin session: https://app.devin.ai/sessions/6647dfd07f80421ca49b42dac633beae
Requested by: @kparkinson-ld
Note
Low Risk
Single devDependency version bump with no application or published-package code changes; only local/test Electron usage is affected.
Overview
Bumps the
electrondevDependency from^7.2.4to^39.8.5inpackage.jsonto clear Dependabot security alerts (use-after-free, renderer injection, ASAR/IPC issues, and related CVEs).Electron is used only for local/testing tooling (e.g.
@jest-runner/electron), not the published SDK, so runtime behavior for consumers is unchanged. Integration tests that rely onspectronmay need a separate follow-up on Electron 39.x compatibility.Reviewed by Cursor Bugbot for commit 1d0ad04. Bugbot is set up for automated code reviews on this repo. Configure here.