Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@ jobs:
strategy:
matrix:
ruby:
- '2.6.10'
- '2.7.8'
- '3.0.7'
- '3.1.5'
- '3.2.4'
- '3.3.1'
- "3.1.7"
- "3.2.9"
- "3.3.10"
- "3.4.7"
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -41,7 +39,7 @@ jobs:
- name: Install Ruby and gems
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3.1
ruby-version: 3.4.7
bundler-cache: true

- name: Run Rubocop
Expand Down
13 changes: 2 additions & 11 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require:
plugins:
- rubocop-performance
- rubocop-rails
- rubocop-rake
Expand All @@ -9,7 +9,7 @@ inherit_gem:
rubocop-shopify: rubocop.yml

AllCops:
TargetRubyVersion: 3.3
TargetRubyVersion: 3.4
NewCops: enable

Layout/EmptyLinesAroundAccessModifier:
Expand Down Expand Up @@ -37,9 +37,6 @@ RSpec/NestedGroups:
RSpec/ExampleLength:
Max: 10

RSpec/ContextWording:
Enabled: false

RSpec/MultipleExpectations:
Enabled: false

Expand All @@ -48,9 +45,3 @@ Rails/ApplicationRecord:

Rails/Date:
Enabled: false

RSpec/FilePath:
Enabled: false

RSpec/SpecFilePathFormat:
Enabled: false
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ and push the `.gem` file to [rubygems.org](https://rubygems.org).

Bug reports and pull requests are welcome on GitHub at https://github.com/lassoid/tiny_filter.


## License

The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
2 changes: 1 addition & 1 deletion spec/tiny_filter/generators/filter_generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def expected_file_content(model_name, keys = [])
# frozen_string_literal: true

class #{class_from_model_name(model_name)}Filter < ::ApplicationFilter
#{keys.any? ? expected_filter_body(keys) : nil}
#{expected_filter_body(keys) if keys.any?}
end
CONTENT
end
Expand Down
3 changes: 2 additions & 1 deletion tiny_filter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,12 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec"
spec.add_development_dependency "rubocop"
spec.add_development_dependency "rubocop-factory_bot"
spec.add_development_dependency "rubocop-performance"
spec.add_development_dependency "rubocop-rails"
spec.add_development_dependency "rubocop-rake"
spec.add_development_dependency "rubocop-rspec"
spec.add_development_dependency "rubocop-shopify"
spec.add_development_dependency "sequel"
spec.add_development_dependency "sqlite3", "~> 1.4" # AR doesn't support 2+
spec.add_development_dependency "sqlite3"
end