feat(drive): document copy workflow guidance - #2184
SongHantian merged 10 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates Lark Drive guidance. Authentication rules are conditional. Search guidance defines strict title matching. Copy guidance defines source selection, token use, limited reads, completion behavior, and error recovery. ChangesLark Drive skill guidance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
skills/lark-drive/references/lark-drive-copy.md (1)
17-22: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy liftAdd executable coverage for the fixed copy contract.
Lines 17-22 define the exact
drive files copyrequest, buttests/cli_e2e/drive/coverage.mdreports no workflow test for this command. Add a contract test that verifies--file-token,data.folder_token,data.name, anddata.type, including rejection of a missingfolder_token. Otherwise, a CLI change can silently invalidate this reference and the routing inskills/lark-drive/SKILL.md.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-drive/references/lark-drive-copy.md` around lines 17 - 22, Add executable contract coverage for the `drive files copy` request documented in `lark-drive-copy.md`, covering `--file-token`, `data.folder_token`, `data.name`, and `data.type`. Include a negative case that rejects a missing `folder_token`, and register the workflow in `tests/cli_e2e/drive/coverage.md` so changes to the CLI contract or `skills/lark-drive/SKILL.md` routing are detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-drive/references/lark-drive-copy.md`:
- Around line 46-50: 在“错误恢复”部分补充 drive files copy 的未知结果处理:对超时、连接重置、5xx
等可能已到达服务端的传输失败不得自动重试;优先使用可用的幂等机制或结果核对,无法核对时先征得用户确认再重试,并保留现有确定性错误的停止规则。
---
Nitpick comments:
In `@skills/lark-drive/references/lark-drive-copy.md`:
- Around line 17-22: Add executable contract coverage for the `drive files copy`
request documented in `lark-drive-copy.md`, covering `--file-token`,
`data.folder_token`, `data.name`, and `data.type`. Include a negative case that
rejects a missing `folder_token`, and register the workflow in
`tests/cli_e2e/drive/coverage.md` so changes to the CLI contract or
`skills/lark-drive/SKILL.md` routing are detected.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 91003c75-5e28-485a-be69-926189f4f313
📒 Files selected for processing (2)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-copy.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@55701fdfd03c05d3a664811fb5e8d84148cc310b🧩 Skill updatenpx skills add SongHantian/cli#auto-research-sync/01KYVM5CMVBXCSZWETFR6Y4VAQ/mr-1358-5fb17c0d -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-drive/SKILL.md`:
- Line 13: 更新认证与确认路由规则,将未结构化但明确表示登录态失败的 Drive/API 错误(包括 `1061005 auth failed`
等资源引用中的错误)纳入读取 `../lark-shared/SKILL.md` 的认证诊断路径;保留 `invalid token`、`not
found`、`unsupported type` 及租户安全策略等确定性业务错误不触发诊断。
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bd261e7f-b4d8-41a7-9b0f-905020f8231e
📒 Files selected for processing (2)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-copy.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-drive/references/lark-drive-copy.md
8b0422f to
dfeadd0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-drive/references/lark-drive-copy.md`:
- Around line 53-54: Update the post-copy guidance in the final
structured-success workflow to state that if drive +copy succeeds but the
following edit fails, retain data.file_token and retry only the edit; do not
repeat the full copy workflow, which could create a duplicate.
In `@skills/lark-drive/references/lark-drive-search.md`:
- Around line 28-29: Update the full-title search guidance to require checking
all paginated drive +search results when has_more=true, using the same query
until either uniqueness is proven or a documented pagination limit is reached.
Permit write operations only for exactly one strict match across the checked
pages; otherwise report no match or list candidates and request clarification.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 31c7909a-5935-4676-b399-bfe6b2fe40f1
📒 Files selected for processing (3)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-copy.mdskills/lark-drive/references/lark-drive-search.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-drive/SKILL.md
5e50600 to
aaedf5e
Compare
Summary
Document the Drive file copy workflow so agents use the native copy API with stable parameters and avoid unnecessary schema, inspect, or metadata calls.
Changes
drive files copyparameters, wiki/folder URL handling, post-copy editing boundaries, and error recovery.files.copyAPI exception.Test Plan
git diff --checkRelated Issues
Auto research task: 01KYVM5CMVBXCSZWETFR6Y4VAQ
Summary by CodeRabbit
New Features
Bug Fixes