Feat: Add more decorations options for Windows platform#8
Open
charlescgs wants to merge 3 commits intolapce:masterfrom
Open
Feat: Add more decorations options for Windows platform#8charlescgs wants to merge 3 commits intolapce:masterfrom
charlescgs wants to merge 3 commits intolapce:masterfrom
Conversation
Collaborator
|
I think I'd rather not merge changes here that aren't merged upstream. We will probably end up switching back and forth as it makes sense just for us to be able to make releases and I don't want that to be breaking users code. We might push this to a different branch here though and add documentation to floem that users can do a [patch.crates-io] and use that branch if they want those features. So maybe we maintain an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jrmoulton Add option for title-bar visibility and resizable borders.
Taken mostly from not merged PRs from official repo #4100 and #4359