Skip to content

Conversation

@krap730
Copy link
Contributor

@krap730 krap730 commented Dec 24, 2025

Summary

Fix workflow-as-tool invocation failing when output variables contain null values.

Problem

When calling a workflow as a tool, if any output variable has a null value, the tool invocation fails with:

1 validation error for VariableMessage
Value error, Only basic types and lists are allowed.

Root Cause

In api/core/tools/entities/tool_entities.py, the VariableMessage.transform_variable_value validator only allows dict | list | str | int | float | bool types, but does not allow None.

When a workflow End node outputs contain null values (e.g., {"result": "data", "optional_field": null}), the WorkflowTool._invoke() method passes these None values to create_variable_message(), which fails the validation.

Solution

Update the validation to allow None values by checking if value is not None before the isinstance check.

Related to #30069

Test Plan

  • Create a workflow with multiple output variables where some may be null
  • Call the workflow as a tool from another workflow or agent
  • Verify that null output values no longer cause validation errors

When calling a workflow as a tool, if any output variable has a null
value, the tool invocation fails with "Only basic types and lists are
allowed" error.

This is because the VariableMessage validator only allows dict, list,
str, int, float, and bool types, but does not allow None.

Workflow End nodes can legitimately output null values for optional
fields, so the validation should accept None as a valid value.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 24, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @krap730, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where workflow-as-tool invocations would fail if any output variable contained a null value. The change updates the VariableMessage validation logic to correctly handle None types, ensuring robust and error-free execution of workflows that produce optional or empty outputs.

Highlights

  • VariableMessage Validation: The transform_variable_value method in VariableMessage now explicitly allows None values, preventing workflow-as-tool invocations from failing when output variables are null.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@krap730
Copy link
Contributor Author

krap730 commented Dec 24, 2025

Note: This issue can also be worked around by ensuring that workflow outputs don't contain null values (e.g., by providing default values in the workflow itself).

Whether to merge this fix is up to the maintainers' discretion - the workaround is a valid alternative if you prefer to keep the stricter validation.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a validation error that occurred when a workflow used as a tool returned null output variables. The change in api/core/tools/entities/tool_entities.py correctly updates the VariableMessage.transform_variable_value validator to permit None values, which was the root cause of the issue. The implementation is clean, and the accompanying updates to the docstring and error message are appreciated for maintaining code clarity. The fix is solid and I see no issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 25, 2025
@crazywoola crazywoola merged commit a26b2d7 into langgenius:main Dec 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants