Skip to content

update: myweather 0.1.0 → 0.1.2#2460

Open
AlexMultiAgent wants to merge 9 commits into
langgenius:mainfrom
AlexMultiAgent:update/myweather-0.1.2
Open

update: myweather 0.1.0 → 0.1.2#2460
AlexMultiAgent wants to merge 9 commits into
langgenius:mainfrom
AlexMultiAgent:update/myweather-0.1.2

Conversation

@AlexMultiAgent
Copy link
Copy Markdown
Contributor

@AlexMultiAgent AlexMultiAgent commented May 25, 2026 •
edited
Loading

1. Metadata

2. Submission Type

  • New plugin submission
  • Version update for existing plugin

3. Description

Update myweather from 0.1.0 to 0.1.2.

Primary change: Internationalization (Japanese & Korean)

The 0.1.0 version only supported English and Chinese. This update adds full Japanese and Korean support at every layer:

Layer What was added
Weather condition translations 146 terms in zh-Hans, zh-Hant, ja, ko (new tools/translations.py, 23 KB)
Language auto-detection CJK ideographs → zh-Hans, Hiragana/Katakana → ja, Hangul → ko via Unicode script analysis
Kanji disambiguation Pure-kanji locations now use country hints (Beijing/zh-Hans, Tokyo/ja, Seoul/ko)
CJK query parsing Japanese/Korean noise tokens and split markers for extracting locations from natural-language queries
UI labels & descriptions All tool parameters, provider labels, and manifest descriptions localized into en_US, zh_Hans, zh_Hant, ja_JP, ko_KR
Summary formatting CJK-format summaries with localized labels (temperature, feels-like, humidity, wind speed)
Error messages Localized error messages in all 5 locales

Secondary changes

  • HTTP retry with exponential backoff for transient network errors (ConnectionError/Timeout/429/503, up to 3 attempts)
  • zh-Hant auto-detection for Taiwan (Taipei), Hong Kong, Macau CJK text
  • Error paths now yield all 14 output variables to avoid breaking downstream Dify workflows
  • Structured logging throughout fetch pipeline
  • Extended CJK Unicode range to cover Compatibility Ideographs (U+F900-U+FAFF)
  • Fix _to_int to use round() instead of truncation
  • Fix English noise word removal to use \b word-boundary regex
  • Fix _as_bool to use explicit allowlist/denylist
  • CJK noise tokens sorted by length (longest first)
  • Defensive guards: empty-candidates check, stricter rate-limit detection
  • Expanded test coverage: 91 tests covering retry logic, mocked upstream API, fallback integration
  • Removed debug log files (plugin_run_*.err/.out), added .gitignore

4. Checklist

  • I have read and followed the Publish to Dify Marketplace guidelines
  • I have read and comply with the Plugin Developer Agreement
  • I confirm my plugin works properly on both Dify Community Edition and Cloud Version
  • I confirm my plugin has been thoroughly tested for completeness and functionality
  • My plugin brings new value to Dify

5. Documentation Checklist

  • Step-by-step setup instructions
  • Detailed usage instructions
  • All required APIs and credentials are clearly listed
  • Connection requirements and configuration details
  • Link to the repository for the plugin source code

6. Privacy Protection Information

Data Collection

This plugin does not collect any user personal data. It sends location queries only to upstream weather APIs (wttr.in, Open-Meteo).

Privacy Policy

  • I confirm that I have prepared and included a privacy policy in my plugin package based on the Plugin Privacy Protection Guidelines

@AlexMultiAgent AlexMultiAgent changed the title update: myweather 0.1.0 → 0.1.2 update: myweather 0.1.0 → 0.1.2 (add Japanese & Korean support) May 25, 2026
@AlexMultiAgent AlexMultiAgent changed the title update: myweather 0.1.0 → 0.1.2 (add Japanese & Korean support) update: myweather 0.1.0 → 0.1.2 May 25, 2026
AlexMultiAgent and others added 5 commits May 26, 2026 22:06
@AlexMultiAgent
update myweather 0.1.2: zh-Hant detection, error-path consistency, HT…
32742ae 
…TP retry fixes

- _resolve_language: TW/HK/MO CJK text now resolves to zh-Hant
- Error/empty paths now yield all 14 output variables for downstream workflow safety
- _retry_request: HTTP 429 and 503 are now retried with exponential backoff
- english_noise tokens sorted by length descending
- Dead ZH_HANS fallback replaced with empty list in _extract_cjk_location_fragments
@AlexMultiAgent
update myweather 0.1.2
de94845
@AlexMultiAgent
update myweather 0.1.2
81037e6
@AlexMultiAgent
update: myweather v0.1.2 — unify temperature unit to °C/°F, replace s…
b0da589 
…creenshots with text examples
@AlexMultiAgent @claude
fix: include _assets/icon.svg in myweather-0.1.2 package
7b2f881 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
crazywoola
crazywoola requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
PR content language ❌ Fail PR title/body CJK ratio=0.6% (zh=14, en=2381, ignored_zh=0, allowed_zh<=0); Chinese characters are not allowed in PR content except configured allowlist snippets. Rewrite the PR title/body in English, excluding only the allowlisted bilingual notice.
README language ❌ Fail README.md CJK ratio=0.6% (zh=20, en=3089, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ❌ Fail PR title/body CJK ratio=0.6% (zh=14, en=2381, ignored_zh=0, allowed_zh<=0); Chinese characters are not allowed in PR content except configured allowlist snippets. Rewrite the PR title/body in English, excluding only the allowlisted bilingual notice.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.1.2 is available. None.
README language ❌ Fail README.md CJK ratio=0.6% (zh=20, en=3089, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements.txt not found; skipped. None.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.
Install test ✅ Pass requirements.txt not found; skipped. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

Please address these issues and push an update.

crazywoola
crazywoola requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
PR content language ❌ Fail PR title/body CJK ratio=0.6% (zh=14, en=2381, ignored_zh=0, allowed_zh<=0); Chinese characters are not allowed in PR content except configured allowlist snippets. Rewrite the PR title/body in English, excluding only the allowlisted bilingual notice.
README language ❌ Fail README.md CJK ratio=0.6% (zh=20, en=3089, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ❌ Fail PR title/body CJK ratio=0.6% (zh=14, en=2381, ignored_zh=0, allowed_zh<=0); Chinese characters are not allowed in PR content except configured allowlist snippets. Rewrite the PR title/body in English, excluding only the allowlisted bilingual notice.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.1.2 is available. None.
README language ❌ Fail README.md CJK ratio=0.6% (zh=20, en=3089, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements.txt not found; skipped. None.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ✅ Pass requirements.txt not found; skipped. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

Please address these issues and push an update.

@AlexMultiAgent
Copy link
Copy Markdown
Contributor Author

AlexMultiAgent commented May 27, 2026 •
edited
Loading

Fix Summary — Review Feedback Addressed

All three failing checks from the review have been resolved:

1. PR Content Language — Fixed

  • PR title and body have been reviewed and no longer contain Chinese characters.
  • All CJK content has been removed from the PR description.

2. README Language — Fixed

  • Removed the Chinese example block (哈尔滨) from README.md.
  • Verified: 0 CJK characters, 3,117 English characters — 0.00% CJK ratio.

3. dify_plugin Version — Fixed

  • Created requirements.txt with dify_plugin>=0.9.0.
  • Moved runtime dependencies from pyproject.toml to requirements.txt (the file read by the Dify marketplace).

Updated Package

The compliant .difypkg package is attached to the release:

CI passed, please re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazywoola crazywoola crazywoola requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexMultiAgent @crazywoola