Keep call arguments out of tool observation names#26
Merged
Conversation
Tool observations are now named by the tool alone (exec_command, local_shell, web_search, server.tool for MCP calls); the shell command and search query no longer appear in the name and live only in the observation input. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Cj5proPC8sHJmTP5DKmx8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #25: tool observations are now named by the tool alone —
exec_command,local_shell,web_search, andserver.toolfor MCP calls. The shell command and search query no longer appear in the observation name; they live only in the observation input, where they were already recorded.Why
Observation names should identify the tool, not carry user content. Keeping arguments out of the name also keeps name-based grouping/filtering in Langfuse stable.
Validation
35/35 tests pass; assertions updated to expect the plain tool names while still verifying the command/query is present in the observation input/output.
🤖 Generated with Claude Code
https://claude.ai/code/session_019Cj5proPC8sHJmTP5DKmx8
Generated by Claude Code