fix(linalg): report AVX-512 test coverage - #8664
Conversation
|
No code change was made: this Review explicitly classifies conditional capable-host CI as a non-blocking risk and says it is not required for #8663's observability fix. The verified current head keeps all 18 checks visible as issue-linked ignored tests, and the supported-host ignored suite passes all 18 tests. |
|
I filed #8663, so here is a note on whether this closes it. Three things I checked and can back up, plus one consequence I read off the diff rather than measured. The "conditional x86 CI pass" the comments reference isn't in the tree. About ten doc comments now read "The conditional x86 CI pass runs this ignored test when AVX-512F is available." This PR touches eight Coverage goes from "sometimes" to "never". A consequence of the same mechanism, which I read off the diff rather than ran (my machine is aarch64, so all of this is The u8 VNNI kernels lose their edge cases. Smaller point: all 18 ignore reasons link to #8663, while the body says Checked and not disputing: If the goal is visibility without giving up coverage, one alternative: leave the runtime detection in place so capable hosts keep running the assertions, and add a single test that always runs and records the detected feature set. The log then distinguishes "ran" from "skipped" without relying on an opt-in path that no job currently uses. |
|
Addressed in df152c2. The 18 runtime-gated tests again run automatically on capable hosts, the u8 VNNI checks retain their full shared-helper edge cases, and ordinary x86 test logs now report the detected ISA features without relying on ignored tests or a nonexistent workflow path. |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The base refresh leaves the reviewed patch unchanged. The always-run x86 feature report remains visible under ordinary test capture, while the runtime-gated AVX-512 and u8 edge-case tests continue to execute automatically on capable hosts.
Summary
Root cause
The AVX-512 feature checks run inside normal test bodies, so unsupported hosts return before the parity assertions and libtest otherwise gives no indication that those paths were skipped.
The new feature-report test writes directly to stderr, bypassing passing-test capture. Every normal x86 test run now records whether each required ISA tier is present, while the existing runtime gates retain automatic direct-kernel coverage on capable hosts.
Validation
cargo test -p lance-linalg test_x86_runtime_feature_report(feature report visible without--nocapture)cargo test -p lance-linalg(219 passed, 0 ignored; all AVX-512 tests executed on the capable validation host)cargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #8663