chore(fsst): drop duplicate arrow-array dev-dependency#7616
Open
LuciferYang wants to merge 1 commit into
Open
Conversation
arrow-array is already declared in [dependencies], which makes it available to tests, examples, and benches. The [dev-dependencies] entry was therefore redundant. No lockfile change (arrow-array remains a workspace dependency).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
arrow-arraywas declared in both[dependencies]and[dev-dependencies]of thefsstcrate. A normal dependency is already visible to tests, examples, and benches, so the[dev-dependencies]entry was redundant. This drops the duplicate line.Tests
No behavior change — purely a dependency-manifest cleanup.
cargo test -p fsst,cargo build -p fsst --example benchmark, andcargo clippy -p fsst --tests --benches -- -D warningsare green. No lockfile change, sincearrow-arrayremains a workspace dependency.