fix(python): preserve PQ num_bits in model training#7583
Open
ddupg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
While building vector indexes through Ray-based distributed indexing, we found that the PQ
num_bitsoption could be ignored by the global PQ training path. The codebook is parameterized by this value: for example, 4-bit PQ should train 16 centroids per sub-vector, while 8-bit PQ trains 256.Before this change, Python/PyO3 PQ training always used 8 bits internally. That can produce a PQ codebook whose bit width does not match the later index build settings, which can make pre-trained PQ artifacts inconsistent with segment construction and hurt quantization/index quality.
Summary
num_bitson Python PQ training helpers and keep the default at 8 bitsnum_bitsthrough the PyO3 PQ training path instead of hard-coding 8num_bitsin savedPqModelmetadata and reuse it when building from pre-trained PQ modelsTests
make build PYTHON=3.12uv run --frozen pytest python/tests/test_indices.py::test_gen_pq python/tests/test_indices.py::test_indices_builder_multivector_distributed_dimensionsuv run --frozen ruff check python/tests/test_indices.pyuv run --frozen ruff format --check python/tests/test_indices.py