fix: implement RowIdMeta.asdict() and from_dict() for stable row ID serialization#6405
Open
pengw0048 wants to merge 1 commit intolance-format:mainfrom
Open
Conversation
c3dd12b to
a3ac7f8
Compare
a3ac7f8 to
3aa2e45
Compare
`FragmentMetadata.to_json()` raised `NotImplementedError` when `row_id_meta` was present (i.e. `enable_stable_row_ids=True`), because `PyRowIdMeta.asdict()` was not implemented. Implement `asdict()` via `pythonize` and add `from_dict()` via `depythonize`, so both serialization and deserialization go directly between Rust and Python dicts without JSON string intermediaries.
3aa2e45 to
a997d63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6403
FragmentMetadata.to_json()raisedNotImplementedErrorwhenrow_id_metawas present (enable_stable_row_ids=True), becausePyRowIdMeta.asdict()was stubbed out. This also brokeFragmentMetadata.from_json()for the round-trip, sinceRowIdMeta(**dict)doesn't work on a PyO3 class.Repro
Fix
PyRowIdMeta.asdict()viapythonize(Rust struct → Python dict)PyRowIdMeta.from_dict()viadepythonize(Python dict → Rust struct)FragmentMetadata.from_json()to useRowIdMeta.from_dict()instead ofRowIdMeta(**dict)test_fragment_metadata_pickleparametrized test