fix: quote column names in merge_insert join to preserve case sensiti…#6397
Open
YSBF wants to merge 1 commit intolance-format:mainfrom
Open
fix: quote column names in merge_insert join to preserve case sensiti…#6397YSBF wants to merge 1 commit intolance-format:mainfrom
YSBF wants to merge 1 commit intolance-format:mainfrom
Conversation
…vity DataFusion's DataFrame::join() lowercases unquoted identifiers, which causes merge_insert to fail when column names contain uppercase letters (e.g. "Stock", "Date"). The join key "target_Stock" is lowercased to "target_stock" internally, but the schema retains "target_Stock", causing a schema mismatch error: No field named target_stock. Did you mean '?table?.Stock'? Fix: wrap join column names in double quotes so DataFusion treats them as quoted identifiers and preserves their original casing. This is consistent with how prefix_columns() already quotes column names when aliasing. Affects both the FullCompatible and Subschema join paths in create_full_table_joined_stream(). The indexed path (create_indexed_joined_stream) is not affected because it uses Column::new_with_schema() which does direct schema lookup.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…vity
DataFusion's DataFrame::join() lowercases unquoted identifiers, which causes merge_insert to fail when column names contain uppercase letters (e.g. "Stock", "Date"). The join key "target_Stock" is lowercased to "target_stock" internally, but the schema retains "target_Stock", causing a schema mismatch error:
No field named target_stock. Did you mean '?table?.Stock'?
Fix: wrap join column names in double quotes so DataFusion treats them as quoted identifiers and preserves their original casing. This is consistent with how prefix_columns() already quotes column names when aliasing.
Affects both the FullCompatible and Subschema join paths in create_full_table_joined_stream(). The indexed path (create_indexed_joined_stream) is not affected because it uses Column::new_with_schema() which does direct schema lookup.