refactor: Deduplicate apply_deletions and promote KeyExistenceFilter to write module#6384
Open
ztorchan wants to merge 1 commit intolance-format:mainfrom
Open
refactor: Deduplicate apply_deletions and promote KeyExistenceFilter to write module#6384ztorchan wants to merge 1 commit intolance-format:mainfrom
ztorchan wants to merge 1 commit intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
apply_deletionsfunction was duplicated across 4 files (delete.rs,update.rs,merge_insert.rs, andmerge_insert/exec.rs) with nearly identical logic. Additionally,KeyExistenceFilterand related types were nested deep insidemerge_insert/inserted_rows.rs, despite being used bytransaction.rsat a higher abstraction level.Changes
Extract
apply_deletionsinto a shared public function inwrite.rspub async fn apply_deletions(dataset, removed_row_addrs)towrite.rsas the single canonical implementation.delete.rs,update.rs,merge_insert.rs, andmerge_insert/exec.rs.Promote
KeyExistenceFiltertowrite/key_existence_filter.rsinserted_rows.rsfrommerge_insert/towrite/askey_existence_filter.rs, making it a direct submodule ofwrite.merge_insert/inserted_rows.rsfile.merge_insert.rs,merge_insert/exec/write.rs, andtransaction.rsto reference the new location.Cleanup
BTreeMap,StreamExt,RoaringTreemap,Fragment, etc.) from files that no longer need them after the refactor.Impact
KeyExistenceFilter(e.g.,write::key_existence_filter::KeyExistenceFilterinstead ofwrite::merge_insert::inserted_rows::KeyExistenceFilter).