fix: cherry-pick for v2.0.0-rc.2 #5795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly (lance-format#5793) In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action). Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Contributor
Review SummaryThis is a cherry-pick PR for v2.0.0-rc.2 that brings two previously merged commits:
P1 Issue FoundTypo in type hint ( The
This means type checkers will flag the correct value as invalid. Should be: blob_handling: Optional[
Literal["all_binary", "blobs_descriptions", "all_descriptions"]
] = None,No Other IssuesThe rest of the changes look correct:
|
…rmat#5759) Closes lance-format#5762 - Replace `@torch.jit.script` with `@torch.compile` in distance.py (6 functions) - Add `torch>=2.0` version constraint - Add filterwarning for PyTorch inductor's use of deprecated `load_module()` - [x] `pytest python/tests/torch_tests/test_distance.py` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fix typo in python.
Co-authored-by: Xuanwo <github@xuanwo.io>
Pandas 3 just released. This caused some tests to fail.
This PR will try to make tests more stable --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
Xuanwo
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.