Skip to content

Conversation

@zhangyue19921010
Copy link
Contributor

@zhangyue19921010 zhangyue19921010 commented Jan 22, 2026

During the invocation of add columns at

pub(crate) async fn merge(mut self, join_column: &str, joiner: &HashJoiner) -> Result<Self> {
, if the left table contains 100 rows of data and the right table contains 10 rows of data (with the remaining 90 rows being null), the validation at
if array.null_count() > 0 && !lance_supports_nulls(array.data_type()) {
will fail.

This is unreasonable because the validation here is a legacy validation that is no longer applicable to V2_0 and above.

ValueError: Invalid user input: Found rows on LHS that do not match any rows on RHS. 
Lance would need to write nulls on the RHS, but Lance does not yet support nulls for type Float32.,
/Users/xxx/xxx/lance/rust/lance/src/dataset/hash_joiner.rs:197:36

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@zhangyue19921010 zhangyue19921010 changed the title fix: data type unreasonable nullable check in hash_joiner during merge operation fix: remove unreasonable nullable check for data types in hash_joiner during merge operation Jan 22, 2026
@github-actions github-actions bot added the bug Something isn't working label Jan 22, 2026
@zhangyue19921010 zhangyue19921010 marked this pull request as draft January 22, 2026 13:36
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 51.11111% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/hash_joiner.rs 50.00% 18 Missing and 3 partials ⚠️
rust/lance/src/dataset/fragment.rs 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@zhangyue19921010 zhangyue19921010 marked this pull request as ready for review January 23, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant