fix: remove unreasonable nullable check for data types in hash_joiner during merge operation #5784
+80
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the invocation of add columns at
lance/rust/lance/src/dataset/fragment.rs
Line 1589 in 8c18429
lance/rust/lance/src/dataset/hash_joiner.rs
Line 192 in 8c18429
This is unreasonable because the validation here is a legacy validation that is no longer applicable to V2_0 and above.