feat: unifying the implementation of transactional commit atomicity across different languages #5774
+660
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
hushengquan
changed the title
hushengquan
force-pushed
the
main
branch
8 times, most recently
from
79e0cb4 to
fe112d4
Compare
…y across different languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Lance added support for distributed compaction and distributed index building. Using these features with Ray requires calling them through the Python API. However, my existing application reads and writes datasets using the Rust API, and the underlying object storage does not support the atomic put-if-not-exist semantic. Therefore, I implemented an
ExternalManifestStoreinterface in Rust. However, when trying to implement distributed compaction based on Ray, I discovered that the transaction atomicity mechanisms in Python and Rust are inconsistent, and only oneCommitHandlercan operate on a single dataset at a time. Therefore, I implemented a mechanism that allows usingExternalManifestCommitHandlerwith the Python API as well, thus achieving atomic transaction commits across different language APIs.issue:#5751