feat: support connecting Python Hive3 Namespace to a Kerberos-secured Hive Metastore#45
Open
zouhuajian wants to merge 1 commit intolance-format:mainfrom
Open
feat: support connecting Python Hive3 Namespace to a Kerberos-secured Hive Metastore#45zouhuajian wants to merge 1 commit intolance-format:mainfrom
zouhuajian wants to merge 1 commit intolance-format:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4caf76f6d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The current Python
Hive3Namespaceimplementation only supports plain Thrift connections to Hive Metastore and cannot connect to Kerberized HMS deployments withhive.metastore.sasl.enabled=true.Changes
This PR adds Kerberos SASL support to the Python
Hive3Namespaceimplementation while keeping the existing non-secure behavior unchanged.Main changes include:
hive.metastore.sasl.enabled=truehive.metastore.kerberos.principalkerberos.service-namekerberos.client-principalhive3dependenciesConfiguration behavior
hive.metastore.sasl.enabledis disabled by defaultkerberos.service-nametakes precedence when explicitly configuredhive.metastore.kerberos.principalkerberos.client-principalis optional; if omitted, local default Kerberos credentials are usedImpact
This change enables the Python Hive3 Namespace to work with Kerberized Hive Metastore deployments without affecting existing non-SASL users.
Testing
This PR includes test updates covering:
Notes
This change is scoped to Kerberos SASL support for the Python Hive3 Namespace only. It does not modify the Java Hive3 implementation and does not introduce a Kerberos integration test environment in this iteration.
Assisted by ChatGPT