Add vector-first Lance ANN path for Cypher vector rerank#140
Merged
beinan merged 4 commits intolance-format:mainfrom Feb 19, 2026
Merged
Add vector-first Lance ANN path for Cypher vector rerank#140beinan merged 4 commits intolance-format:mainfrom
beinan merged 4 commits intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Add getter methods to core VectorSearch struct (column, get_query_vector, get_metric, get_top_k) to allow Python bindings to access internal state - Remove duplicated fields from Python VectorSearch, keeping only inner and use_lance_index - Refactor python_datasets_to_batches functions to share common logic - Fix Lance test to use FixedSizeListArray for vector column - Add test for WHERE clause fallback behavior - Improve documentation in try_execute_with_lance_index Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
Manual Test Results ✅Ran manual verification of the vector-first Lance ANN feature: Test Setup
Results
Test OutputObservations
Minor NoteThe vector-first path doesn't include the |
- Add Python tests for use_lance_index edge cases: - Missing query_vector error - Fallback for non-Lance datasets - Unqualified column names - Builder flag propagation - Cosine and dot product metrics - Add Rust unit tests for helper functions: - split_vector_column parsing - alias_map_from_query extraction - resolve_vector_label resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ChunxuTang
approved these changes
Feb 19, 2026
Collaborator
ChunxuTang
left a comment
There was a problem hiding this comment.
Currently, the use_lance_index=False will generate a _distance column, but the use_lance_index=True won't. I think it's better to consolidate them in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Motivation
Using Lance datasets with ANN indices can significantly reduce latency for GraphRAG hybrid retrieval on large datasets by avoiding full-table reranking.