Conversation
defstyled supports using another styled component as the tag argument (e.g. `(defstyled inherited base ...)`), but the hook always flagged non-keyword tags as invalid. Similarly, styled component symbols in rules (e.g. `bold` in `(defstyled heading :h1 bold :text-3xl)`) were misidentified as the function tail. - Track defstyled symbols via atom to validate styled component tags - Skip token nodes in fn-tag detection to avoid false positives - Reference symbol tags in output nodes to prevent unresolved warnings - Remove leftover debug prn calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
defstyled supports using another styled component as the tag argument
(e.g.
(defstyled inherited base ...)), but the hook always flaggednon-keyword tags as invalid. Similarly, styled component symbols in
rules (e.g.
boldin(defstyled heading :h1 bold :text-3xl)) weremisidentified as the function tail.
Tests added
defstyledhook, covering both valid and invalid patternsclj-kondo --lintwith EDN output format and assert onornament/invalid-syntaxfindings