perf(l1): batch merkelization requests if the queue is not empty #5200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark Block Execution Results Comparison Against Main
|
MegaRedHand
reviewed
Nov 11, 2025
MegaRedHand
reviewed
Nov 11, 2025
Oppen
approved these changes
Nov 11, 2025
jrchatruc
approved these changes
Nov 11, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** Currently for every transaction being executed, we get the transitions and send the updates to the merkelization thread. However this has two drawbacks: - getting the update list isn't cheap, taking up 10% of block execution - unbatched requests cause more work to be done, increasing total merkelization time The merkelization queue often had dozens of requests by the end of block execution. **Description** We delay calculating and sending updates until the merkelizer is ready (queue is empty), which causes the changes to the batched. --------- Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently for every transaction being executed, we get the transitions and send the updates to the merkelization thread.
However this has two drawbacks:
The merkelization queue often had dozens of requests by the end of block execution.
Description
We delay calculating and sending updates until the merkelizer is ready (queue is empty), which causes the changes to the batched.