cairo1-run: honor relocate_mem and trace_enabled when relocating #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
commented
Oct 23, 2025
sashass1315
commented
- Fix cairo1-run to use Cairo1RunConfig.relocate_mem and trace_enabled in runner.relocate(...) instead of unconditionally relocating both memory and trace.
- This change brings Cairo1-run behavior in line with the Cairo 0.x runner, matches CLI expectations (trace/memory requested ⇒ relocate), and avoids unnecessary relocation work.
Contributor
|
Hi @sashass1315, thanks for the contribution! Left you a small comment. Also, format seems to be failing. |
Co-authored-by: Julian Gonzalez Calderon <gonzalezcalderonjulian@gmail.com>
gabrielbosio
requested changes
Nov 6, 2025
Collaborator
gabrielbosio
left a comment
gabrielbosio
left a comment
There was a problem hiding this comment.
Left a small suggestion. Also please fix the linter job.
Collaborator
|
Hi @sashass1315! Any news on this PR? |
Co-authored-by: Gabriel Bosio <38794644+gabrielbosio@users.noreply.github.com>
Author
Hi! Updated PR! thank you for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.