Freeze a docx without the bracketed spans the PDF generator cannot compile - #84
Open
peterbjohnson wants to merge 2 commits into
Open
peterbjohnson wants to merge 2 commits into
peterbjohnson wants to merge 2 commits into
Conversation
…r cannot compile (t58)
…r cannot compile (t58)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three docx sheets in the MECH60014 folder fault at build with
the PDF generator cannot compile this: Undefined control sequenceon fields that hold**[Question 2:]{.underline}**: pandoc's docx reader writes an underlined run as a bracketed span with theunderlineclass, and the PDF generator's pandoc turns it into a command the template does not define. Underline is formatting the set does not carry, and Lambda Feedback's markdown has no underline.Freeze a docx without bracketed spans: write with
commonmark_x-bracketed_spans(or strip[text]{.underline}totextafter the freeze, if the extension flag also drops something the freeze needs - say which in the PR), so the field holds**Question 2:**. Check the other docx-only constructs pandoc emits in the same way -{.mark},{.smallcaps},[text]{custom-style=...}- and drop the attributes the same way. Add a docx fixture under tests/fixtures/sources/ holding an underlined heading and a highlighted word (write it with python-docx in a script kept beside it, and say so in the folder README), with expected.json, and a test that the frozen markdown holds no{.attribute. Done when the three sheets' fields compile: reproduce with the fixture, since the sheets are private.Workbench ticket t58.