Support Python predicates in specs - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 2. Where selectors are not enough, a spec names predicates from a Python file beside it: functions over panflute elements that say whether a block is a question, part or solution. The predicate file's hash goes in the draft with the spec's, so a changed predicate invalidates the draft. Corpus testing decides how often this is needed, so keep it minimal. Done when a spec in the test data uses a predicate and produces its expected draft, and a spec whose predicate file is missing or changed since the draft was made is refused.
Workbench ticket t27.