Make the old CLI form fail loudly - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work from main. This lands after PR #24 is merged, so do not start before then. The findings, with reproductions, are in the review comment: #24 (comment)
Moving conversion under a subcommand leaves the old form silently doing nothing. Given an absolute path, or one starting ./, in2lambda prints its usage and exits successfully without converting anything. Only a bare filename fails properly. Every Docker invocation and every script passing a full path will therefore appear to succeed and produce no files.
Done when the old form cannot be mistaken for success, and whoever used it is told what to run instead.
This is also a breaking change to a published command line, and the package version and release notes do not say so yet.
Workbench ticket t14.