Repository navigation
fix(vhost): match virtual host names case-insensitively - #3212
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewVirtualHostHandlerlooks the request host up in the map exactly as it arrived, soHost: OK.commisses an instance registered asok.comand falls through to the fallback Echo instance, which usually has different routes and middleware. Host names are case insensitive (RFC 9110 Section 4.2.3), and non-browser clients do send mixed case. This lowercases the keys once at construction and lowercasesr.Hoston lookup. Copying the map is a small behaviour change: mutating it after construction no longer affects routing, and the doc comment now says so. I added one row to the existing table test.