feat(dataset): add retrieval trace to dataset search response - #7644
feat(dataset): add retrieval trace to dataset search response#7644Ultronen wants to merge 1 commit into
Conversation
|
Ultronen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thanks for working on retrieval observability. I checked the diff at
The current tests cover a simple embedding path and an empty result, but do not exercise mixed/image recall, rerank success/fallback, Agent propagation, dispatch persistence, or UI rendering. Those cases would catch the semantic issues above. |
Expose text and image recall branches, merged filtering stages, rerank status, and Agent chunk selection in dataset-search response details. Keep the trace payload limited to candidate counts and comparable score ranges. Closes labring#7113
33b18f9 to
c1ac524
Compare
|
Thanks for the detailed review. I addressed the points in
I also added focused coverage for the shared/persisted schema, mixed text-image branches, rerank success and fallback, standalone dispatch, Agent propagation and LLM selection, and UI rendering. The 5 focused test files pass with 28 tests, together with app typecheck, targeted ESLint/Prettier, and the i18n loader check. The branch is updated onto the latest |
|
Hi @c121914yu, following up now that c1ac524 addresses all five points from your review: branched recall plus an explicit merge boundary, Agent-path propagation and LLM selection tracing, explicit rerank status, comparable score ranges only, and shared typed/static-i18n stage names. The branch is still mergeable, the CLA check passes, and the focused suite covers the shared schema, mixed text/image recall, rerank success/fallback, standalone and Agent dispatch, LLM selection, and UI rendering (28 tests). When you have time, could you take another look? I am ready to handle any follow-up quickly. |
Related issue
Closes #7113
Problem
When a RAG workflow returns a wrong or incomplete answer, the response detail only shows the surviving quotes. It does not show whether a chunk was never recalled, dropped during rerank, or removed by later filters.
Summary
Adds an optional
retrievalTraceto dataset-search responses:applied,skipped, orfallback.Scope and compatibility
Verification
pnpm --filter @fastgpt/app typecheckpnpm check:i18n-loadersgit diff --check