feat: add accessible DataTable column resizing - #46
Merged
Merged
Conversation
Replace mouse-only resize listeners with pointer capture and use the rendered header width as the drag baseline, preventing jumps in fluid tables. Add labelled keyboard separators with 16 px Arrow controls, Home minimum reset, visible token-based grips, and cleanup for cancellation, lost capture, and unmount. Tests cover rendered-width drag starts, pointer cleanup, minimum clamping, keyboard values, consumer labels, and sort isolation. `pnpm run verify` passes with the package check rerun under an isolated npm cache because the shared cache has root-owned files. Refs #45
Add a finite 1200px default maximum and optional column maximum, track rendered header widths through ResizeObserver, and expose bounded ARIA values with a consumer-supplied value formatter. Make pointer cleanup pointer-scoped and reentrant-safe, reject non-primary and secondary input, reserve a 32px token hit target, and guard the grip's light and dark contrast. Tests cover responsive measurements, bounds, multi-pointer cleanup, formatting, target size, and contrast. Refs #45
Apply the 1200px default maximum only to resizable columns. A noResize column now retains its legacy minimum-only width behavior unless its consumer explicitly supplies maxWidth, which remains enforced. Add regressions for a 1600px fixed column and an explicitly bounded fixed column. `pnpm run verify` passes with the isolated npm cache. Refs #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm run verifypassed through build; its pack check also passed when rerun with an isolated npm cache because the shared cache contains root-owned files.Closes #45