test: cover the two Select cases only a consumer had - #39
Merged
Merged
Conversation
Closing #16 turned up a correction: the proposal said neither product had a `Select` test, which was true of backend.ai-go and wrong about continuum-hub, whose five tests predate this admission. The package's fifteen covered four of them. These are the other two. Arrow keys skip a disabled option, not just a click, and a select without `searchable` renders no search field and every option. Both were only guarded in a consumer, which is the wrong place for a property of this component. Verified against the perturbations: letting the keyboard land on disabled options fails three tests, rendering the search field unconditionally fails one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the correction in #16.
That proposal said neither product shipping
Selecthad a test for it. True ofbackend.ai-go, wrong aboutcontinuum-hub, which has had five since its #969 and #1062. The fifteen tests admitted with the component in #37 covered four of the five.These are the other two, and both are properties of the component rather than of any consumer:
searchablerenders no search field, and shows every option.Verified against the perturbations that should break them: letting keyboard navigation land on disabled options fails three tests, rendering the search field unconditionally fails one.
No source change, so no release is needed for this; it rides the next one.
Refs #16