Merged
Conversation
🦋 Changeset detectedLatest commit: 7ec9911 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e6b5705 to
b8a3f50
Compare
This also moves the test to use msw
b8a3f50 to
7ec9911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates to dependencies, testing, and configuration for the
@labdigital/graphql-fetcherpackage. The most notable change is the migration of tests fromvitest-fetch-mocktomsw, providing more robust and realistic HTTP request mocking. Additional changes include updating dependencies, refining Biome linting configuration, and switching the build tool fromtsuptotsdown.Dependency and build tool updates:
package.jsonto their latest versions, including@apollo/server-gateway-interface,@biomejs/biome,@changesets/cli,@graphql-typed-document-node/core,@types/react,@vitest/coverage-v8, and replacedtsupwithtsdownas the build tool. Addedmswfor HTTP mocking, and specified apnpmoverride forrollup.package.jsonto usetsdowninstead oftsup.Testing improvements:
src/client.test.ts,src/server.test.ts) from usingvitest-fetch-mocktomswfor HTTP mocking. This includes setting up a mock server, using handlers for HTTP requests, and updating assertions to use spies on the global fetch function. This results in more realistic and reliable test scenarios for GraphQL fetchers. [1] [2]mswhandlers and fetch spies, ensuring proper cleanup and more accurate call assertions in both client and server tests. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Configuration and linting enhancements:
biome.jsonto improve file inclusion rules, refine linting settings (especially for console usage and suspicious code), and update the nursery configuration. [1] [2] [3]Code quality and minor fixes:
src/client.tsby refining the query string generation logic and cleaning up variable initialization. [1] [2]These changes collectively modernize the package, improve test reliability, and ensure better code quality and maintainability.